"Skipping duplicate agent skill name" log spam

[aeschli]

No description provided.

[Copilot]

Pull request overview

Reduces noisy Window output logging during agent skill discovery by downgrading several skill-validation/discovery warnings to debug, addressing repeated “Skipping duplicate agent skill name” spam reported in multi-root / multi-skill-source setups.

Changes:

• Downgraded skill name/description sanitization warnings (XML tag stripping, truncation) from warn to debug.
• Downgraded skill discovery warnings (missing name fallback, name mismatch, duplicate-name skip) from warn to debug.
• Minor cleanup in the affected logging block (removed an extra blank line).

[Copilot]

The log prefix here says [findAgentSkills], but these messages are emitted from truncateAgentSkillName / truncateAgentSkillDescription and can also happen during validateAndSanitizeSkillFile (extension-contributed skills) and computeSkillDiscoveryInfo. Consider updating the prefix to reflect the helper/function emitting the message so logs are easier to trace.

[Copilot]

This log message claims the folder name will be used when the sanitized name doesn't match, but the code continues using sanitizedName for duplicate detection and for the loaded entry. Either adjust the message to match the behavior, or actually switch to using the folder name in this branch (consistent with the agentskills folder-name spec and the wording of the message).

See below for a potential fix:

				const headerName = parsedFile.header?.name;
				let name = headerName;

				if (!name) {
					this.logger.debug(`[computeSkillDiscoveryInfo] Agent skill file missing name attribute, using folder name "${folderName}": ${uri}`);
					name = folderName;
				}

				const sanitizedName = this.truncateAgentSkillName(name, uri);
				const folderSanitizedName = this.truncateAgentSkillName(folderName, uri);
				let effectiveName = sanitizedName;

				if (headerName && sanitizedName !== folderName) {
					this.logger.debug(`[computeSkillDiscoveryInfo] Agent skill name "${sanitizedName}" does not match folder name "${folderName}", using folder name: ${uri}`);
					effectiveName = folderSanitizedName;
				}

				if (seenNames.has(effectiveName)) {
					this.logger.debug(`[computeSkillDiscoveryInfo] Skipping duplicate agent skill name: ${effectiveName} at ${uri}`);
					files.push({ uri, storage, status: 'skipped', skipReason: 'duplicate-name', name: effectiveName, duplicateOf: nameToUri.get(effectiveName), extensionId, source });
					continue;
				}

				const description = parsedFile.header?.description;

				seenNames.add(effectiveName);
				nameToUri.set(effectiveName, uri);
				const disableModelInvocation = parsedFile.header?.disableModelInvocation === true;
				const userInvocable = parsedFile.header?.userInvocable !== false;
				files.push({ uri, storage, status: 'loaded', name: effectiveName, description, extensionId, source, disableModelInvocation, userInvocable });