Fix enter key behavior in integrated browser#303910
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes broken Enter handling in the Integrated Browser by ensuring plain Enter is no longer rerouted through VS Code keybinding dispatch (and thus reaches the embedded page normally), while preserving the “add focused element to chat” functionality via a modified keybinding.
Changes:
- Change “Add Focused Element to Chat” keybinding from
EntertoCtrl/Cmd+Enterwhen element selection is active. - Stop treating
Enteras a “non-editing key” inBrowserView.tryHandleCommand, so it won’t be intercepted/rerouted without modifiers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorChatFeatures.ts | Updates the chat-related action keybinding to avoid consuming plain Enter while still allowing an explicit modified shortcut. |
| src/vs/platform/browserView/electron-main/browserView.ts | Ensures plain Enter is handled natively by the embedded page by removing it from the non-editing reroute set. |
lszomoru
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303906