Fix get_task_output empty results for background tasks while preserving single-run reused terminal behavior#304124
Merged
meganrogge merged 2 commits intomerogge/task-output-fixfrom Mar 23, 2026
Conversation
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/8fd5025d-67a0-4524-b23d-4e4af4c3dd8e
Copilot
AI
changed the title
[WIP] Fix get task output empty results for background tasks
Fix get_task_output empty results for background tasks while preserving single-run reused terminal behavior
Mar 23, 2026
meganrogge
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_task_outputreturned empty output for background/watch tasks because output collection started from a fresh end-of-buffer marker rather than the existing terminal content.Changes:
startMarkersByTerminalInstanceIdmap type fromtypeof terminals[number]['registerMarker'](brittle, breaks ifterminalsincludesundefined) toMap<number, IXtermMarker | undefined>, matching the stable type used intaskHelpers.tscollectTerminalResultsand its post-processing intry/finallysostore.dispose()always runs even whencollectTerminalResultsthrows — aligning withrunTaskTool.tsandcreateAndRunTaskTool.tsstartMarkersByTerminalInstanceIdmap with per-terminal entries set toundefined, causingcollectTerminalResultsto read from the full current buffer instead of a newly created end-of-buffer marker; single-run tasks retain existing marker behavior to avoid pulling in unrelated prior output from reused terminals📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.