Use bracketed paste mode for run_in_terminal tool

[meganrogge]

fixes #296955

[Copilot]

Pull request overview

This PR aims to address #296955 by ensuring terminal commands sent by the run_in_terminal chat tool use bracketed paste mode, which avoids multiline input corruption around the ~1024 byte boundary on some PTY/shell combinations.

Changes:

• Enable bracketed paste when sending command text in the “none” execute strategy.
• Extend ITerminalInstance.runCommand / TerminalInstance.runCommand with an optional bracketedPasteMode parameter and incorporate it into sendText behavior.
• Update the basic strategy’s SIGINT send path to pass bracketedPasteMode: true (currently problematic; see comments).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File	Description
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/noneExecuteStrategy.ts	Sends executed command text with bracketed paste enabled.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/basicExecuteStrategy.ts	Changes SIGINT send to request bracketed paste (risky for correctness).
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts	Adds bracketedPasteMode to runCommand and uses it when sending text.
src/vs/workbench/contrib/terminal/browser/terminal.ts	Updates ITerminalInstance.runCommand signature to include bracketedPasteMode.

Comments suppressed due to low confidence (2)

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts:1018

• runCommand forwards bracketedPasteMode to the pre-execution Ctrl+C send. If callers enable bracketed paste for multiline commands, this will wrap the ETX character in bracketed paste sequences (when supported) and may prevent SIGINT from working reliably. Consider always sending Ctrl+C without bracketed paste (omit the 3rd arg or pass false) and only using bracketedPasteMode for the command payload itself.

			await this.sendText('\x03', false, bracketedPasteMode);

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts:1024

• The comment says bracketed paste is used only when not running the command, but the new logic enables bracketed paste when bracketedPasteMode is set even for executed commands. Update the comment to reflect the new behavior so future readers don’t assume executed commands never use bracketed paste.

		// Use bracketed paste mode only when not running the command
		await this.sendText(commandLine, shouldExecute, !shouldExecute || bracketedPasteMode);

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

addressed