Skip to content

add debounce for working shimmer #304285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justschen merged 3 commits into from
Mar 23, 2026
Merged

add debounce for working shimmer #304285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a387bd
add debounce for working shimmer
justschen Mar 23, 2026
0c12f79
Update src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts
justschen Mar 23, 2026
d54c93c
revert ccr
justschen Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ import { isMcpToolInvocation } from './chatContentParts/toolInvocationParts/chat
const $ = dom.$;

const COPILOT_USERNAME = 'GitHub Copilot';
const WORKING_CAUGHT_UP_DEBOUNCE_MS = 50;

export interface IChatListItemTemplate {
currentElement?: ChatTreeItem;
Expand Down Expand Up @@ -1067,7 +1068,7 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
if (
!lastPart ||
lastPart.kind === 'references' ||
(lastPart.kind === 'markdownContent' && !moreContentAvailable) ||
(lastPart.kind === 'markdownContent' && !moreContentAvailable && this.hasBeenCaughtUpLongEnough(element)) ||
((lastPart.kind === 'toolInvocation' || lastPart.kind === 'toolInvocationSerialized') && (IChatToolInvocation.isComplete(lastPart) || lastPart.presentation === 'hidden')) ||
((lastPart.kind === 'textEditGroup' || lastPart.kind === 'notebookEditGroup') && lastPart.done && !partsToRender.some(part => part.kind === 'toolInvocation' && !IChatToolInvocation.isComplete(part))) ||
(lastPart.kind === 'progressTask' && lastPart.deferred.isSettled) ||
Expand All @@ -1081,6 +1082,17 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
return false;
}

/**
* Adds a debounce on when to show "working" shimmer.
*/
private hasBeenCaughtUpLongEnough(element: IChatResponseViewModel): boolean {
const lastRenderTime = element.renderData?.lastRenderTime;
if (typeof lastRenderTime !== 'number' || lastRenderTime === 0) {
return false;
}
return (Date.now() - lastRenderTime) >= WORKING_CAUGHT_UP_DEBOUNCE_MS;
}


private getChatFileChangesSummaryPart(element: IChatResponseViewModel): IChatChangesSummaryPart | undefined {
if (!this.shouldShowFileChangesSummary(element)) {
Expand Down
Loading