Skip to content

fix: re-layout list when toggling browse mode in MCP/plugin widgets #304286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshspicer merged 1 commit into from
Mar 23, 2026
Merged

fix: re-layout list when toggling browse mode in MCP/plugin widgets #304286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,8 @@ export class McpListWidget extends Disposable {
private galleryServers: IWorkbenchMcpServer[] = [];
private searchQuery: string = '';
private browseMode: boolean = false;
private lastHeight: number = 0;
private lastWidth: number = 0;
private readonly collapsedGroups = new Set<string>();
private galleryCts: CancellationTokenSource | undefined;
private readonly delayedFilter = new Delayer<void>(200);
Expand Down Expand Up @@ -608,6 +610,11 @@ export class McpListWidget extends Disposable {
this.galleryServers = [];
this.filterServers();
}

// Re-layout to account for the back link height change
if (this.lastHeight > 0) {
this.layout(this.lastHeight, this.lastWidth);
}
}

private async queryGallery(): Promise<void> {
Expand Down Expand Up @@ -882,6 +889,8 @@ export class McpListWidget extends Disposable {
* Layouts the widget.
*/
layout(height: number, width: number): void {
this.lastHeight = height;
this.lastWidth = width;
const sectionFooterHeight = this.sectionHeader.offsetHeight || 0;
const searchBarHeight = this.searchAndButtonContainer.offsetHeight || 52;
const backLinkHeight = this.browseMode ? (this.backLink.offsetHeight || 28) : 0;
Expand Down
9 changes: 9 additions & 0 deletions src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ export class PluginListWidget extends Disposable {
private marketplaceItems: IMarketplacePluginItem[] = [];
private searchQuery: string = '';
private browseMode: boolean = false;
private lastHeight: number = 0;
private lastWidth: number = 0;
private readonly collapsedGroups = new Set<string>();
private marketplaceCts: CancellationTokenSource | undefined;
private readonly delayedFilter = new Delayer<void>(200);
Expand Down Expand Up @@ -519,6 +521,11 @@ export class PluginListWidget extends Disposable {
this.marketplaceItems = [];
this.filterPlugins();
}

// Re-layout to account for the back link height change
if (this.lastHeight > 0) {
this.layout(this.lastHeight, this.lastWidth);
}
}

private async queryMarketplace(): Promise<void> {
Expand Down Expand Up @@ -692,6 +699,8 @@ export class PluginListWidget extends Disposable {
}

layout(height: number, width: number): void {
this.lastHeight = height;
this.lastWidth = width;
const sectionFooterHeight = this.sectionHeader.offsetHeight || 0;
const searchBarHeight = this.searchAndButtonContainer.offsetHeight || 52;
const backLinkHeight = this.browseMode ? (this.backLink.offsetHeight || 28) : 0;
Expand Down
Loading