Remove self from notify, classifier, events, etc.#304498
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes references to a former maintainer (“Tyriar”) across repository metadata and telemetry ownership annotations, updating responsible contacts/owners and modernizing a node-pty issue link.
Changes:
- Update telemetry
ownerfields for several terminal/perf events to new maintainers. - Update GitHub triage metadata (classifier assignments, CODE NOTIFY mappings, issue-notebook queries) to remove “Tyriar”.
- Update ancillary references (proposed d.ts comment attribution,
.mailmapentry removal, node-pty issue URL migration).
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.terminalShellEnv.d.ts | Removes “Tyriar” from attribution comment in proposed API d.ts. |
| src/vs/workbench/contrib/terminalContrib/typeAhead/browser/terminalTypeAheadAddon.ts | Updates GDPR/telemetry owner for terminalLatencyStats. |
| src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkManager.ts | Updates telemetry owner for terminal/openLink. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalToolTelemetry.ts | Updates telemetry owners for run-in-terminal tool events. |
| src/vs/workbench/contrib/terminal/browser/terminalTelemetry.ts | Updates telemetry owner for terminal creation event. |
| src/vs/workbench/contrib/performance/browser/inputLatencyContrib.ts | Updates telemetry owners for input latency event. |
| src/vs/platform/terminal/node/terminalProcess.ts | Updates node-pty issue links to microsoft/node-pty. |
| .vscode/notebooks/verification.github-issues | Removes -author:Tyriar from saved GitHub query. |
| .vscode/notebooks/my-endgame.github-issues | Removes -author:Tyriar from saved GitHub query macro. |
| .mailmap | Removes the Tyriar mailmap entry. |
| .github/classifier.json | Reassigns several labels away from “Tyriar”. |
| .github/CODENOTIFY | Updates terminal platform path notifications away from “Tyriar”. |
anthonykim1
reviewed
Mar 24, 2026
| @@ -1,4 +1,3 @@ | |||
| Daniel Imms <daimms@microsoft.com> Daniel Imms <tyriar@tyriar.com> | |||
anthonykim1
approved these changes
Mar 24, 2026
|
@Tyriar what's going on? Why did u left? 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @meganrogge