prompts: fix agent plugin hooks being picked up multiple times#304523
Merged
connor4312 merged 3 commits intomainfrom Mar 24, 2026
Merged
prompts: fix agent plugin hooks being picked up multiple times#304523connor4312 merged 3 commits intomainfrom
connor4312 merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicate collection of agent plugin hooks by ensuring plugin-provided hook entries returned from listPromptFiles(PromptsType.hook) are not also parsed as regular hook files, since plugin hooks are collected separately from agentPluginService.
Changes:
- Skip
PromptsStorage.pluginentries during the hook-file parsing loop incomputeHooks. - Rely exclusively on the existing “Collect hooks from agent plugins” path for plugin hooks.
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Show resolved
Hide resolved
roblourens
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.