Skip to content

set chat tips to true, always elevate AI profiles#304553

Merged
meganrogge merged 2 commits intomainfrom
merogge/exps
Mar 24, 2026
Merged

set chat tips to true, always elevate AI profiles#304553
meganrogge merged 2 commits intomainfrom
merogge/exps

Conversation

@meganrogge
Copy link
Collaborator

Copilot AI review requested due to automatic review settings March 24, 2026 19:14
@meganrogge meganrogge self-assigned this Mar 24, 2026
@meganrogge meganrogge added this to the 1.114.0 milestone Mar 24, 2026
@meganrogge meganrogge enabled auto-merge (squash) March 24, 2026 19:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes chat tips enabled by default and removes the experimental toggle for elevating AI-contributed terminal profiles, making AI profile elevation always-on in the new terminal dropdown.

Changes:

  • Set chat.tips.enabled default to true and remove its experimental/experiment metadata.
  • Remove the terminal.integrated.experimental.aiProfileGrouping setting and enum entry.
  • Update terminal dropdown action construction to always split/elevate AI profiles and remove configuration-based gating.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts Removes the experimental setting schema for AI profile grouping.
src/vs/platform/terminal/common/terminal.ts Removes the TerminalSettingId.ExperimentalAiProfileGrouping enum entry.
src/vs/workbench/contrib/terminal/browser/terminalMenus.ts Makes AI profile elevation unconditional; updates getTerminalActionBarArgs signature to no longer require configuration.
src/vs/workbench/contrib/terminal/browser/terminalView.ts Updates calls to getTerminalActionBarArgs and removes config-change handling for the removed setting.
src/vs/workbench/contrib/terminal/browser/terminalEditor.ts Updates calls to getTerminalActionBarArgs to match the new signature.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Changes chat tips default to enabled and removes experimental tagging/experiment config.

@meganrogge meganrogge merged commit fad70f3 into main Mar 24, 2026
19 checks passed
@meganrogge meganrogge deleted the merogge/exps branch March 24, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants