agentPlugins: allow root dir source

[connor4312]

No description provided.

[Copilot]

Pull request overview

Enables marketplace plugins to be sourced from the repository root directory by treating an empty source (and implicitly missing source) as the repo root when no pluginRoot is provided.

Changes:

• Update plugin source resolution to allow empty source to resolve to repo root instead of undefined.
• Adjust parsePluginSource test expectations for empty source without pluginRoot.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/vs/workbench/contrib/chat/common/plugins/pluginMarketplaceService.ts	Removes the empty-source early return so repo-root sources resolve to '' (relative path).
src/vs/workbench/contrib/chat/test/common/plugins/pluginMarketplaceService.test.ts	Updates the unit test to expect repo-root resolution for empty source without pluginRoot.

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/common/plugins/pluginMarketplaceService.ts:786

• After removing the empty-source special-case, resolvePluginSource will always return a string (including '' for repo root) for file URIs, so the string | undefined return type is now misleading and the resolved === undefined checks in parsePluginSource are effectively dead. Consider updating the return type/JSDoc to reflect that '' is a valid result (or reintroduce an explicit undefined outcome if callers rely on it to skip entries).

function resolvePluginSource(pluginRoot: string | undefined, source: string): string | undefined {
	const normalizedRoot = pluginRoot ? normalizeMarketplacePath(pluginRoot) : '';
	const normalizedSource = normalizeMarketplacePath(source);
	const repoRoot = URI.file('/');
	const pluginRootUri = normalizedRoot ? normalizePath(joinPath(repoRoot, normalizedRoot)) : repoRoot;

	if (normalizedRoot && (normalizedSource === normalizedRoot || normalizedSource.startsWith(`${normalizedRoot}/`))) {
		return normalizedSource;
	}

	const resolvedUri = normalizePath(joinPath(pluginRootUri, normalizedSource));
	return relativePath(repoRoot, resolvedUri) ?? undefined;