timeline: fix memory leak when toggling pane visibility#304668
Merged
bpasero merged 4 commits intomicrosoft:mainfrom Mar 27, 2026
Merged
timeline: fix memory leak when toggling pane visibility#304668bpasero merged 4 commits intomicrosoft:mainfrom
bpasero merged 4 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DisposableStore leak in the Timeline view by ensuring previously-created visibility-scoped disposables are disposed before creating a new set when the pane is shown again.
Changes:
- Dispose
this.visibilityDisposablesbefore reinitializing it inTimelinePane.setVisible(true)to prevent leaking event listeners/disposables across repeatedsetVisible(true)calls.
xingsy97
changed the title
bryanchen-d
approved these changes
Mar 25, 2026
bpasero
approved these changes
Mar 25, 2026
rzhao271
approved these changes
Mar 25, 2026
Member
Author
|
According to CI error log, it seems the CI pipeline itself is broken, not caused by PR change. Re-run didn't help. Could someone help take a look? Thanks! @bryanchen-d @bpasero @rzhao271 |
Collaborator
|
We've filed an internal incident report for the GitHub runners. Nothing mitigated yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TimelinePane.setVisible(true)creates a newDisposableStoreassigned tothis.visibilityDisposableswithout first disposing the old one. IfsetVisible(true)is called twice in succession (e.g. view becomes visible → user switches away and back quickly), the first set of disposables leaks.Fix
Dispose the existing
visibilityDisposablesbefore creating a new store, preventing the leak.