Also do attach for goto symbols#304841
Merged
TylerLeonhardt merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
a missed part of #304521 this adds the same handling of shift+enter for goto symbols just like anything & workspace symbols quick access.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Go to Symbol in Editor Quick Access (@) with the “attach via Shift+Enter” behavior already supported in other Quick Access providers (e.g. Anything / Workspace Symbols), enabling symbol picks to be attached (e.g. to chat context) instead of navigating.
Changes:
- Extend
IGotoSymbolQuickPickItem.attachto receive modifier state and the accept event. - Intercept
onDidAcceptto delegate toattachwhen Shift is held, skipping navigation.
eleanorjboyd
approved these changes
Mar 25, 2026
justschen
pushed a commit
that referenced
this pull request
Mar 26, 2026
a missed part of #304521 this adds the same handling of shift+enter for goto symbols just like anything & workspace symbols quick access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a missed part of #304521
this adds the same handling of shift+enter for goto symbols just like anything & workspace symbols quick access.