Skip to content

add diffs to thinking headers#304967

Merged
justschen merged 2 commits intomainfrom
justin/deino
Mar 26, 2026
Merged

add diffs to thinking headers#304967
justschen merged 2 commits intomainfrom
justin/deino

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

Screenshot 2026-03-25 at 5 40 02 PM

adds diffs from code blocks into the header for better edit visibility

Copilot AI review requested due to automatic review settings March 26, 2026 00:52
@vs-code-engineering vs-code-engineering bot added this to the 1.114.0 milestone Mar 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the chat “thinking/working” UI by surfacing aggregated edit diff stats (+/-) from edit code-block pills directly in the thinking header, improving visibility of edit impact while the list is collapsed.

Changes:

  • Plumbs an aggregated diff-change event from ChatMarkdownContentPart up into ChatThinkingContentPart.
  • Renders the aggregated +added/-removed counts in the thinking header and styles them via CSS.
  • Adds diff-change emission from edit code-block pills and aggregates those stats per markdown part.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Passes markdown-part diff-change event into thinking-part item appends.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatThinkingContent.css Adds styling for the new diff stats segment in the thinking header.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts Aggregates diff stats per appended markdown part and renders totals in the finalized title.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatMarkdownContentPart.ts Emits aggregated diff stats from edit pills and wires pill diff updates into the aggregation.

@justschen justschen marked this pull request as ready for review March 26, 2026 01:15
@justschen justschen merged commit a283b74 into main Mar 26, 2026
18 checks passed
@justschen justschen deleted the justin/deino branch March 26, 2026 05:27
mjbvz pushed a commit to mjbvz/vscode that referenced this pull request Mar 26, 2026
* add diffs to thinking headers

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants