chore: additional error categories for macOS cert api#305154
Merged
deepak1556 merged 2 commits intomainfrom Mar 26, 2026
Merged
chore: additional error categories for macOS cert api#305154deepak1556 merged 2 commits intomainfrom
deepak1556 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned Microsoft build identifiers for the Electron (root) and Node (remote) native header downloads, presumably to pick up macOS system certificate error-category changes referenced in the linked issue.
Changes:
- Bump Electron headers
ms_build_idin.npmrc. - Bump Node headers
ms_build_idinremote/.npmrc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.npmrc |
Updates Electron headers ms_build_id to a newer Microsoft build. |
remote/.npmrc |
Updates Node headers ms_build_id to a newer Microsoft build for remote builds. |
chrmarti
approved these changes
Mar 26, 2026
mjbvz
pushed a commit
to mjbvz/vscode
that referenced
this pull request
Mar 26, 2026
* chore: additional error categories for macOS cert api * chore: bump distro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #287739
Additional error categories to
tls.getSystemCACertificatesErrorsapi