Add experiment for sign in button in title bar by cwebster-99 · Pull Request #305723 · microsoft/vscode

cwebster-99 · 2026-03-27T16:14:35Z

Adds setting for the following experimental behavior:

Copilot

Pull request overview

Adds an experimental configuration/experiment to surface a “Sign In” affordance in the custom title bar area for signed-out Copilot users, aligning with existing title bar indicator patterns.

Changes:

Introduces chat.signInTitleBar.enabled as an experimental, auto-enrolled experiment-backed setting.
Adds a new TitleBarAdjacentCenter action + custom action view item to render a “Sign In” button styled like the update indicator.
Updates the chat status bar “Signed out” label to “Sign In”.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/vs/workbench/contrib/chat/common/constants.ts	Adds new `ChatConfiguration.SignInTitleBarEnabled` setting key constant.
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusEntry.ts	Changes signed-out status label text to “Sign In”.
src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts	Registers title-bar-adjacent sign-in action + custom view item via `IActionViewItemService`.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts	Registers the new experimental setting with experiment metadata.

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts:845

This entry relies on the .update-indicator CSS that’s currently imported by the update contribution (updateTitleBarEntry.ts). That creates a hidden cross-feature dependency: if the update contribution/CSS isn’t loaded (or the class names/styles change), the sign-in button styling will break. Consider adding chat-owned styling (new CSS class) or explicitly importing the required stylesheet so the dependency is intentional and stable.

		const content = dom.append(container, dom.$('.update-indicator.prominent'));
		content.setAttribute('role', 'button');
		content.setAttribute('aria-label', this.action.label);
		const label = dom.append(content, dom.$('.indicator-label'));
		label.textContent = this.action.label;

Copilot · 2026-03-27T16:20:34Z

src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusEntry.ts

 			// Signed out
 			else if (this.chatEntitlementService.entitlement === ChatEntitlement.Unknown) {
-				const signedOutWarning = localize('notSignedIn', "Signed out");
+				const signedOutWarning = localize('notSignedIn', "Sign In");


The localization key notSignedIn previously corresponded to “Signed out”, but now maps to “Sign In”. Reusing the same key will keep existing translations for “Signed out” in non-English builds, resulting in incorrect UI text. Use a new localization key (e.g. signIn) when changing the meaning of a string so translators get updated source text.

Suggested change

const signedOutWarning = localize('notSignedIn', "Sign In");

const signedOutWarning = localize('signIn', "Sign In");

Copilot · 2026-03-27T16:20:34Z

src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts

+		const content = dom.append(container, dom.$('.update-indicator.prominent'));
+		content.setAttribute('role', 'button');
+		content.setAttribute('aria-label', this.action.label);


SignInTitleBarEntry.render sets role="button" and aria-label on the inner .update-indicator element, but the actual actionable/focusable element is the action view item container (BaseActionViewItem wires events/focus on container). This can lead to confusing semantics for assistive tech (nested button-like element that isn’t focusable). Prefer applying accessible labeling/role to the view item container (or follow the update indicator pattern and avoid adding a separate role on a child element).

This issue also appears on line 841 of the same file.

Suggested change

const content = dom.append(container, dom.$('.update-indicator.prominent'));

content.setAttribute('role', 'button');

content.setAttribute('aria-label', this.action.label);

container.setAttribute('aria-label', this.action.label);

const content = dom.append(container, dom.$('.update-indicator.prominent'));

Copilot · 2026-03-27T16:20:34Z

src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts

+		this._register(actionViewItemService.register(
+			MenuId.TitleBarAdjacentCenter,
+			'workbench.action.chat.signInIndicator',
+			(action, options) => new SignInTitleBarEntry(action, options)


Avoid duplicating the action id string; ChatSetupSignInTitleBarAction already defines static readonly ID. Reusing the constant here prevents future mismatches if the id changes.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-27T20:08:15Z

src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts

+class SignInTitleBarEntry extends BaseActionViewItem {
+
+	constructor(
+		action: IAction,
+		options: IBaseActionViewItemOptions,
+	) {
+		super(undefined, action, options);
+	}
+
+	public override render(container: HTMLElement) {
+		super.render(container);
+
+		container.setAttribute('aria-label', this.action.label);
+
+		const content = dom.append(container, dom.$('.update-indicator.prominent'));
+		const label = dom.append(content, dom.$('.indicator-label'));
+		label.textContent = this.action.label;
+	}


SignInTitleBarEntry extends BaseActionViewItem but doesn’t override updateLabel / updateEnabled. Since BaseActionViewItem wires onDidChange and calls these methods, label/enablement changes won’t be reflected and the UI may stay clickable even if the action becomes disabled. Consider implementing these overrides (and storing the created label/content elements) or extending an action view item class that already handles label/disabled rendering, similar to UpdateTitleBarEntry.

Copilot · 2026-03-27T20:08:15Z

src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts

+		const content = dom.append(container, dom.$('.update-indicator.prominent'));
+		const label = dom.append(content, dom.$('.indicator-label'));
+		label.textContent = this.action.label;


This title bar entry reuses the .update-indicator/.indicator-label styling classes, but those styles are defined in workbench/contrib/update CSS (updateTitleBarEntry.css) and aren’t imported here. That creates a hidden cross-feature dependency and risks unstyled UI if the update contribution/CSS changes or isn’t loaded. Consider adding chat-owned styling (or explicitly importing the required CSS in this feature) instead of relying on update’s internal classes.

Copilot · 2026-03-27T20:08:15Z

src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts

+		class ChatSetupSignInTitleBarAction extends Action2 {
+
+			static readonly ID = SIGN_IN_TITLE_BAR_ACTION_ID;
+
+			constructor() {
+				super({
+					id: ChatSetupSignInTitleBarAction.ID,
+					title: localize('signInIndicatorTitleBarAction', 'Sign In'),
+					f1: false,
+					menu: [{
+						id: MenuId.TitleBarAdjacentCenter,
+						order: 0, // same position as the update button
+						when: ContextKeyExpr.and(
+							ContextKeyExpr.has(`config.${ChatConfiguration.SignInTitleBarEnabled}`),
+							ChatContextKeys.Entitlement.signedOut,
+							ChatContextKeys.Setup.hidden.negate(),
+							ContextKeyExpr.has('updateTitleBar').negate()
+						),
+					}]
+				});


ChatSetupSignInTitleBarAction is registered unconditionally, but the associated view-item registration is gated to Electron-only (isWeb early return). In web builds, this action can still contribute a menu item to MenuId.TitleBarAdjacentCenter (with default rendering) even though the feature is intended to be Electron-only. Consider skipping registerAction2(ChatSetupSignInTitleBarAction) (or gating the menu when) when isWeb is true so the action doesn’t surface in web.

Add experiment for sign in button in title bar

0bd9e10

Copilot AI review requested due to automatic review settings March 27, 2026 16:14

vs-code-engineering bot added this to the Backlog milestone Mar 27, 2026

Copilot started reviewing on behalf of cwebster-99 March 27, 2026 16:17 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

vs-code-engineering bot assigned cwebster-99 Mar 27, 2026

Polish for experiment gating

9d6cdc3

cwebster-99 requested a review from Copilot March 27, 2026 19:58

cwebster-99 linked an issue Mar 27, 2026 that may be closed by this pull request

Reuse title bar update for sign in nudge #305704

Closed

Copilot started reviewing on behalf of cwebster-99 March 27, 2026 20:02 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

polish

fea1308

cwebster-99 requested review from dmitrivMS and eli-w-king March 27, 2026 20:52

cwebster-99 marked this pull request as ready for review March 27, 2026 20:53

Merge branch 'main' into open-wren

48a5303

justschen approved these changes Mar 27, 2026

View reviewed changes

cwebster-99 merged commit 8d8e32f into main Mar 27, 2026
28 of 29 checks passed

cwebster-99 deleted the open-wren branch March 27, 2026 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add experiment for sign in button in title bar#305723

Add experiment for sign in button in title bar#305723
cwebster-99 merged 4 commits intomainfrom
open-wren

cwebster-99 commented Mar 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	const signedOutWarning = localize('notSignedIn', "Sign In");
	const signedOutWarning = localize('signIn', "Sign In");

Conversation

cwebster-99 commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cwebster-99 commented Mar 27, 2026 •

edited

Loading