Don't use trusted telemetry value on model ids#305760
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts AI edit telemetry so that modelId is no longer emitted as a TelemetryTrustedValue, aligning the event payload with untrusted telemetry cleaning expectations.
Changes:
- Remove
TelemetryTrustedValueusage formodelIdineditTelemetry.codeSuggestedandeditTelemetry.codeAccepted. - Sanitize
modelIdbefore logging (currently replacing/with_).
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryServiceImpl.ts:169
- Same as above:
data.modelId?.replace('/', '_')only replaces the first/, so model ids with multiple path separators may still be redacted during telemetry cleaning. Use a global replacement (and consider matchingavoidPathRedactionbehavior fromsrc/vs/editor/common/textModelEditSource.ts).
modeId: data.modeId,
modelId: data.modelId?.replace('/', '_'),
applyCodeBlockSuggestionId: data.applyCodeBlockSuggestionId as unknown as string,
...kbench/contrib/editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryServiceImpl.ts
Outdated
Show resolved
Hide resolved
...kbench/contrib/editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryServiceImpl.ts
Show resolved
Hide resolved
anthonykim1
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @hediet, as discussed. You may nee to update some dashboards that use this event