Sessions - more improvements to the changes view

[lszomoru]

No description provided.

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@jrieken

Matched files:

• src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts

[Copilot]

Pull request overview

Improves the Sessions window “Changes” experience by adjusting the version picker/UI layout and making session-changes toolbar actions less dependent on hasAgentSessionChanges for visibility (to address missing controls in some views).

Changes:

• Adds a new “Branch Changes” version mode (and updates defaults) plus supporting session/git metadata observables.
• Tweaks changes view layout/empty-state placement and minor header styling.
• Relaxes ChatEditingSessionChangesToolbar menu visibility conditions across actions (view all changes / code review / apply submenu).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts	Removes when: hasAgentSessionChanges from the “View All Changes” toolbar contribution.
src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts	Moves “has changes” gating from menu visibility into the action’s precondition.
src/vs/sessions/contrib/changes/browser/media/changesView.css	Adds small spacing tweak for action-label text next to icons.
src/vs/sessions/contrib/changes/browser/changesView.ts	Introduces new version modes/defaults and adds new derived session/git metadata for the picker + adjusts empty state placement/visibility.
src/vs/sessions/contrib/applyCommitsToParentRepo/browser/applyChangesToParentRepo.ts	Makes the Apply Actions submenu entry visible based only on Sessions window context.

Comments suppressed due to low confidence (2)

src/vs/sessions/contrib/changes/browser/changesView.ts:1611

• All Changes and Last Turn's Changes are disabled unless checkpoint refs exist, but the current rendering logic only treats LastTurn specially—AllChanges currently shows the same entries as BranchChanges. Either implement checkpoint-based behavior for AllChanges or remove the checkpoint gating/extra mode to avoid a misleading UI state.

						...action,
						id: 'chatEditing.versionsAllChanges',
						label: localize('chatEditing.versionsAllChanges', 'All Changes'),
						description: localize('chatEditing.versionsAllChanges.description', 'Show all changes made in this session'),
						checked: viewModel.versionModeObs.get() === ChangesVersionMode.AllChanges,
						category: { label: 'checkpoints', order: 2, showHeader: false },
						enabled: viewModel.activeSessionFirstCheckpointRefObs.get() !== undefined &&
							viewModel.activeSessionLastCheckpointRefObs.get() !== undefined,
						run: async () => {

src/vs/sessions/contrib/changes/browser/changesView.ts:783

• combinedEntriesObs only branches on ChangesVersionMode.LastTurn; BranchChanges and AllChanges currently produce identical results. With the new Branch Changes option, this looks incomplete and will confuse users (the picker changes but the list doesn't). Consider adding explicit handling for BranchChanges (e.g. base↔HEAD diff) and/or AllChanges (checkpoint range) so each mode maps to distinct data.

		// Combine both entry sources for display
		const combinedEntriesObs = derived(reader => {
			const headCommit = headCommitObs.read(reader);
			const sessionFiles = sessionFilesObs.read(reader);
			const versionMode = this.viewModel.versionModeObs.read(reader);

			let sourceEntries: IChangesFileItem[];
			if (versionMode === ChangesVersionMode.LastTurn) {
				const lastTurnDiffChanges = lastTurnChangesObs.read(reader).read(reader);
				const lastCheckpointRef = this.viewModel.activeSessionLastCheckpointRefObs.read(reader);

				const diffChanges = lastTurnDiffChanges ?? [];

				const ref = lastCheckpointRef
					? lastCheckpointRef
					: headCommit;

				const parentRef = lastCheckpointRef
					? `${lastCheckpointRef}^`
					: headCommit ? `${headCommit}^` : undefined;

				sourceEntries = diffChanges.map(change => {
					const isDeletion = change.modifiedUri === undefined;
					const isAddition = change.originalUri === undefined;
					const uri = change.modifiedUri ?? change.uri;
					const fileUri = isDeletion
						? uri
						: ref
							? uri.with({ scheme: 'git', query: JSON.stringify({ path: uri.fsPath, ref }) })
							: uri;
					const originalUri = isAddition
						? change.originalUri
						: parentRef
							? fileUri.with({ scheme: 'git', query: JSON.stringify({ path: fileUri.fsPath, ref: parentRef }) })
							: change.originalUri;
					return {
						type: 'file',
						uri: fileUri,
						originalUri,
						state: ModifiedFileEntryState.Accepted,
						isDeletion,
						changeType: isDeletion ? 'deleted' : isAddition ? 'added' : 'modified',
						linesAdded: change.insertions,
						linesRemoved: change.deletions,
						reviewCommentCount: 0,
						agentFeedbackCount: 0,
					} satisfies IChangesFileItem;
				});
			} else {
				sourceEntries = [...sessionFiles];
			}