Skip to content

Sessions - fix all changes rendering#306005

Merged
lszomoru merged 1 commit intomainfrom
lszomoru/agricultural-goat
Mar 28, 2026
Merged

Sessions - fix all changes rendering#306005
lszomoru merged 1 commit intomainfrom
lszomoru/agricultural-goat

Conversation

@lszomoru
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 28, 2026 19:42
@lszomoru lszomoru enabled auto-merge (squash) March 28, 2026 19:42
@lszomoru lszomoru self-assigned this Mar 28, 2026
@lszomoru lszomoru added this to the 1.114.0 milestone Mar 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Agent Sessions Changes view rendering logic to better support “All Changes” and “Last Turn” diff-based views (aimed at fixing rendering glitches/incorrect refresh).

Changes:

  • Updates repository resolution to open a git repository using workingDirectory (and now fallback to uri).
  • Introduces an allChangesObs observable (diff between first/last checkpoint refs) alongside the existing “last turn” diff.
  • Reworks loading/progress gating and entry combination based on the selected ChangesVersionMode.
Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/changes/browser/changesView.ts:341

  • workingDirectory now falls back to activeSessionRepository?.uri and is passed to gitService.openRepository(...). For some session providers the repo uri can be non-local/read-only (e.g. vscode-agent-host), which other sessions components explicitly treat as unsupported. Add a scheme guard (at least for AGENT_HOST_SCHEME, and likely require file when appropriate) before calling openRepository, otherwise this can trigger failed repo opens / stuck loading in the Changes view.
			const activeSessionRepository = activeSessionRepositoryObs.read(reader);
			const workingDirectory = activeSessionRepository?.workingDirectory ?? activeSessionRepository?.uri;
			if (!workingDirectory) {
				return constObservable(undefined);
			}

			return new ObservablePromise(this.gitService.openRepository(workingDirectory)).resolvedValue;

@lszomoru lszomoru merged commit ba7d21e into main Mar 28, 2026
22 checks passed
@lszomoru lszomoru deleted the lszomoru/agricultural-goat branch March 28, 2026 20:22
Copy link
Copy Markdown

@rajoonrohi-star rajoonrohi-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants