Skip to content

sessions - update item height when approving#306146

Merged
bpasero merged 1 commit intomainfrom
ben/convincing-cricket
Mar 29, 2026
Merged

sessions - update item height when approving#306146
bpasero merged 1 commit intomainfrom
ben/convincing-cricket

Conversation

@bpasero
Copy link
Copy Markdown
Member

@bpasero bpasero commented Mar 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 29, 2026 19:43
@bpasero bpasero enabled auto-merge (squash) March 29, 2026 19:43
@bpasero bpasero self-assigned this Mar 29, 2026
@vs-code-engineering vs-code-engineering bot added this to the Backlog milestone Mar 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agent Sessions window’s sessions list so session row heights are recalculated using the tree delegate’s height computation when an approval row is shown/hidden, ensuring the list updates correctly after approval state changes.

Changes:

  • Reuses a single SessionsTreeDelegate instance for the WorkbenchObjectTree construction.
  • Updates the session item height recalculation handler to pass an explicit computed height via delegate.getHeight(session).

@bpasero bpasero merged commit 2e20252 into main Mar 29, 2026
22 checks passed
@bpasero bpasero deleted the ben/convincing-cricket branch March 29, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants