Skip to content

fix(chat): increase z-index of chat editing overlay to appear above feedback overlay (#306360)#306409

Open
speedsters wants to merge 4 commits intomicrosoft:mainfrom
speedsters:fix/306360-remove-keep-action-overlap
Open

fix(chat): increase z-index of chat editing overlay to appear above feedback overlay (#306360)#306409
speedsters wants to merge 4 commits intomicrosoft:mainfrom
speedsters:fix/306360-remove-keep-action-overlap

Conversation

@speedsters
Copy link
Copy Markdown

Summary

Fixes issue #306360 where the "Keep" action in the chat editing overlay appears underneath the "Submit Feedback" button in the agent feedback overlay.

Problem

When both the chat editing overlay (with Keep/Undo actions) and agent feedback overlay (with Submit Feedback) are visible, they share the same z-index (100) and position. This causes the "Keep" action to appear underneath the feedback submit button, making it inaccessible to users.

Root Cause

Both overlays had the same z-index value (100):

  • ChatEditingOverlayController: z-index 100
  • AgentFeedbackOverlayController: z-index 100

Fix

Increased the z-index of ChatEditingOverlayController from 100 to 101 so it renders on top of the AgentFeedbackOverlayController.

Testing

All z-index values verified:

  • ChatEditingEditorOverlay.ts: z-index = 101 ✓
  • AgentFeedbackEditorOverlay.ts: z-index = 100 ✓

Fixes #306360

@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering bot commented Mar 30, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@jrieken

Matched files:

  • src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorOverlay.ts

@speedsters
Copy link
Copy Markdown
Author

@speedsters please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sessions: There should not be Keep action underneath Feedback submit action

2 participants