fix(chat): increase z-index of chat editing overlay to appear above feedback overlay (#306360)#306409
Open
speedsters wants to merge 4 commits intomicrosoft:mainfrom
Open
fix(chat): increase z-index of chat editing overlay to appear above feedback overlay (#306360)#306409speedsters wants to merge 4 commits intomicrosoft:mainfrom
speedsters wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jriekenMatched files:
|
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #306360 where the "Keep" action in the chat editing overlay appears underneath the "Submit Feedback" button in the agent feedback overlay.
Problem
When both the chat editing overlay (with Keep/Undo actions) and agent feedback overlay (with Submit Feedback) are visible, they share the same z-index (100) and position. This causes the "Keep" action to appear underneath the feedback submit button, making it inaccessible to users.
Root Cause
Both overlays had the same z-index value (100):
ChatEditingOverlayController: z-index 100AgentFeedbackOverlayController: z-index 100Fix
Increased the z-index of
ChatEditingOverlayControllerfrom 100 to 101 so it renders on top of theAgentFeedbackOverlayController.Testing
All z-index values verified:
Fixes #306360