Skip to content

Add exit code and command output to runInTerminal telemetry #306750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isidorn merged 1 commit into from
Mar 31, 2026
+3 −0
Merged

Add exit code and command output to runInTerminal telemetry #306750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalToolTelemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ export class RunInTerminalToolTelemetry {
requestUnsandboxedExecutionReason: string | undefined;
outputLineCount: number;
nonZeroExitCode: -1 | 0 | 1;
exitCodeValue: number;
timingConnectMs: number;
pollDurationMs: number;
timingExecuteMs: number;
Expand Down Expand Up @@ -159,6 +160,7 @@ export class RunInTerminalToolTelemetry {
requestUnsandboxedExecutionReason: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The reason the model gave for requesting unsandboxed execution, if any' };
outputLineCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How many lines of output were produced, this is -1 when isBackground is true or if there\'s an error' };
nonZeroExitCode: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the command exited with a non-zero code (-1=error/unknown, 0=zero exit code, 1=non-zero)' };
exitCodeValue: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; isMeasurement: true; comment: 'The actual exit code of the terminal command (-1 if unknown)' };
timingConnectMs: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How long the terminal took to start up and connect to' };
timingExecuteMs: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How long the terminal took to execute the command' };
pollDurationMs: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'How long the tool polled for output, this is undefined when isBackground is true or if there\'s an error' };
Expand Down Expand Up @@ -187,6 +189,7 @@ export class RunInTerminalToolTelemetry {
requestUnsandboxedExecutionReason: state.requestUnsandboxedExecutionReason,
outputLineCount: state.outputLineCount,
nonZeroExitCode: state.exitCode === undefined ? -1 : state.exitCode === 0 ? 0 : 1,
exitCodeValue: state.exitCode ?? -1,
timingConnectMs: state.timingConnectMs,
timingExecuteMs: state.timingExecuteMs,
pollDurationMs: state.pollDurationMs ?? 0,
Expand Down
Loading