Conversation
justschen
previously approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #307276 by changing the “Allow repository in this session” pre-confirm action for external paths so it no longer no-ops when a git root cannot be determined, instead falling back to allowing the containing folder for the current chat session.
Changes:
- Update repo-allow action to fall back to allowing the containing folder when no git root is found.
- Add unit tests covering session allowlisting behavior (folder/repo), git-root caching, and the fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/tools/builtinTools/chatExternalPathConfirmation.ts | Changes repo-allow selection to add folderUri when git root lookup fails, instead of returning false/no-op. |
| src/vs/workbench/contrib/chat/test/common/tools/builtinTools/chatExternalPathConfirmation.test.ts | Adds test coverage for session allowlisting, git-root caching, and the git-root-not-found fallback. |
connor4312
previously approved these changes
Apr 2, 2026
justschen
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should fallback to folder and "allow" the folder instead of no-op
cc @connor4312