Skip to content

chat - fix migration of completed key#307345

Merged
bpasero merged 1 commit intomainfrom
ben/conceptual-camel
Apr 2, 2026
Merged

chat - fix migration of completed key#307345
bpasero merged 1 commit intomainfrom
ben/conceptual-camel

Conversation

@bpasero
Copy link
Copy Markdown
Member

@bpasero bpasero commented Apr 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 2, 2026 06:06
@bpasero bpasero enabled auto-merge (squash) April 2, 2026 06:06
@bpasero bpasero self-assigned this Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the one-time storage migration for chat.setupContext so that the completed setup state is migrated correctly from older state and persisted, ensuring Chat setup UI/context keys reflect the migrated completion state across restarts.

Changes:

  • Tightens the migration condition to only set completed when installed is true and completed is not already set.
  • Persists the migrated completed state back into profile storage during the migration step.

Comment thread src/vs/workbench/services/chat/common/chatEntitlementService.ts
Comment thread src/vs/workbench/services/chat/common/chatEntitlementService.ts
@bpasero bpasero merged commit f7b7a34 into main Apr 2, 2026
23 checks passed
@bpasero bpasero deleted the ben/conceptual-camel branch April 2, 2026 09:03
@vs-code-engineering vs-code-engineering bot added this to the 1.115.0 milestone Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants