Sessions - bulk update context keys to avoid flickering#307497
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets UI flicker in the Sessions “Artifacts/Changes” view by updating multiple context keys in a single buffered batch, ensuring action visibility/enabled state doesn’t rapidly toggle while session/repository state is still loading.
Changes:
- Introduces per-instance
IContextKey<T>fields bound once in theChangesViewPaneconstructor. - Centralizes and bulk-updates related context keys via a new
_bindContextKeys(...)helper usingbufferChangeEvents. - Uses cached/structurally-compared derived observables to avoid redundant context key updates and reduce action flicker.
Yoyokrazy
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.