Paste clipboard file resource in terminal when text is empty#307501
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves terminal paste behavior by falling back to clipboard “resources” (e.g. copied files) when the clipboard has no text, enabling pasting a file path into the integrated terminal.
Changes:
- Update
TerminalClipboardContribution.paste()to use the first clipboard resource’s path whenreadText()is empty. - Add unit tests covering text paste, resource fallback, and empty clipboard behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminal.clipboard.contribution.ts |
Adds resource-based fallback logic when clipboard text is empty. |
src/vs/workbench/contrib/terminalContrib/clipboard/test/browser/terminalClipboard.test.ts |
Adds tests validating the new paste behavior and edge cases. |
anthonykim1
changed the title
eleanorjboyd
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #301603
After the PR:
https://github.com/user-attachments/assets/7db3269a-146a-47da-b003-0578ca3da580