Skip to content

sessions: Update title bar actions and styles for improved navigation#307538

Merged
osortega merged 1 commit intomainfrom
copilot/patient-penguin
Apr 3, 2026
Merged

sessions: Update title bar actions and styles for improved navigation#307538
osortega merged 1 commit intomainfrom
copilot/patient-penguin

Conversation

@osortega
Copy link
Copy Markdown
Contributor

@osortega osortega commented Apr 3, 2026

Reorganize the title bar session toolbar for better grouping and navigation.

Changes

  • Reorder toolbar actions: Run Script (8) → Open in VS Code (9) → Open Terminal (10) → Changes toggle (11)
  • Always-visible VS Code button: Removed IsActiveSessionBackgroundProviderContext from the menu when clause so the Open in VS Code button is visible for all session types, but disabled when no worktree is available (via the existing precondition). This avoids a hacky placeholder action.
  • Relocated separator: Moved the toolbar separator from between the two toolbar containers to between session-specific actions (Run, VS Code) and fixed toggles (Terminal, Changes). Uses a broader CSS selector ([class*="codicon-vscode"]) for resilience across icon variants.
  • Renamed dropdown category: "Add" → "Tasks" in the run script dropdown for clarity.
  • New unit test: Verifies the run dropdown submenu is contributed to TitleBarSessionMenu at order 8.

Files changed

File What
titlebarpart.css Remove old separator between toolbar containers
changesTitleBarWidget.ts Update order to 11
changesTitleBarWidget.css Add new intra-toolbar separator CSS
chat.contribution.ts Reorder VS Code action to 9, remove when guard so it stays visible but disabled
runScriptAction.ts Rename "Add" → "Tasks", update comments
sessionsTerminalContribution.ts Reorder terminal action to 10, sort imports
runScriptAction.test.ts New test for menu contribution

Reorganize the title bar session toolbar for better grouping and
navigation:

- Reorder toolbar actions: Run Script (8), Open in VS Code (9), Open
  Terminal (10), Changes toggle (11)
- Show Open in VS Code button for all sessions, disabled when no
  worktree is available (uses existing precondition instead of a
  separate placeholder action)
- Move separator from between toolbar containers to between session
  actions (Run, VS Code) and fixed toggles (Terminal, Changes) using
  a broader CSS selector for vscode icon variants
- Rename 'Add' category to 'Tasks' in the run script dropdown
- Add unit test for run dropdown menu contribution

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 3, 2026 00:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorganizes the Agent Sessions title bar session toolbar to improve action grouping and navigation, including updates to action ordering, styling separators, and a small labeling tweak in the Run dropdown, plus a new unit test to validate menu contribution order.

Changes:

  • Reordered TitleBarSessionMenu actions to: Run (8) → Open in VS Code (9) → Open Terminal (10) → Changes (11), and adjusted related when clauses.
  • Moved the visual separator from between toolbar containers to within the session actions toolbar (between VS Code and Terminal).
  • Renamed the Run dropdown category header from “Add” to “Tasks” and added a unit test asserting the Run submenu is contributed at order 8.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/sessions/browser/parts/media/titlebarpart.css Removed the previous inter-container separator styling.
src/vs/sessions/contrib/changes/browser/changesTitleBarWidget.ts Updated Changes toggle action order to 11.
src/vs/sessions/contrib/changes/browser/media/changesTitleBarWidget.css Added an intra-toolbar separator after the VS Code action.
src/vs/sessions/contrib/chat/browser/chat.contribution.ts Reordered “Open in VS Code” to order 9 and made it always visible (disabled via precondition).
src/vs/sessions/contrib/chat/browser/runScriptAction.ts Renamed dropdown category label to “Tasks” and updated related comments/usages.
src/vs/sessions/contrib/terminal/browser/sessionsTerminalContribution.ts Reordered Terminal action to order 10 and adjusted import ordering.
src/vs/sessions/contrib/chat/test/browser/runScriptAction.test.ts Added unit test verifying Run submenu contribution/order in TitleBarSessionMenu.

Comment thread src/vs/sessions/contrib/chat/browser/chat.contribution.ts
@osortega osortega enabled auto-merge (squash) April 3, 2026 00:34
@osortega osortega merged commit 1254a3c into main Apr 3, 2026
23 checks passed
@osortega osortega deleted the copilot/patient-penguin branch April 3, 2026 00:45
@vs-code-engineering vs-code-engineering Bot added this to the 1.115.0 milestone Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants