Ensure that ssh2/cpu-features doesn't get shipped#307546
Merged
roblourens merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Optional dependency that we don't want to use. This shouldn't be necessary, but if it somehow ends up getting built/installed at some point, let's strip it from the build Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a defensive packaging cleanup rule to ensure the optional native dependency cpu-features (pulled in via ssh2) is not shipped in VS Code builds, even if it gets installed/built inadvertently.
Changes:
- Exclude
cpu-features/**from packagednode_modulesviabuild/.moduleignore.
vijayupadya
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional dependency that we don't want to use. This shouldn't be necessary, but if it somehow ends up getting built/installed at some point, let's strip it from the build
Co-authored-by: Copilot copilot@github.com