Skip to content

chat: remove Preview label and customizationsMenu.enabled setting#307744

Merged
joshspicer merged 1 commit intomainfrom
copilot/inadequate-mollusk
Apr 7, 2026
Merged

chat: remove Preview label and customizationsMenu.enabled setting#307744
joshspicer merged 1 commit intomainfrom
copilot/inadequate-mollusk

Conversation

@joshspicer
Copy link
Copy Markdown
Member

Summary

The Chat Customizations editor is no longer behind a preview gate. This PR:

  • Removes the (Preview) suffix from the "Open Customizations" and "Customizations" command titles
  • Removes the chat.customizationsMenu.enabled setting and its ChatCustomizationMenuEnabled constant
  • Simplifies all when-clauses/preconditions to only check ChatContextKeys.enabled instead of also checking the now-removed setting
  • Removes the legacy gear submenu fallback that was shown when the setting was disabled
  • Cleans up unused ChatConfiguration imports from 3 files
  • Updates AI_CUSTOMIZATIONS.md documentation to reflect the removal

Changes by file

File Change
constants.ts Remove ChatCustomizationMenuEnabled enum member
chat.contribution.ts Remove setting registration
aiCustomizationManagement.contribution.ts Remove (Preview) from titles, simplify preconditions, remove unused import
chatActions.ts Simplify when-clauses, remove legacy gear submenu fallback
chatOpenAgentDebugPanelAction.ts Simplify when-clause, remove unused import
toolSetsContribution.ts Simplify when-clause, remove unused import
agentTitleBarStatusWidget.ts Remove setting check from shouldForceHiddenAgentStatus and config change listeners
commandCenterControl.ts Remove constant and setting check from compact-mode logic
AI_CUSTOMIZATIONS.md Remove references to the deleted setting

Copilot AI review requested due to automatic review settings April 3, 2026 22:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the preview gating around the Chat Customizations editor by deleting the chat.customizationsMenu.enabled setting, dropping the (Preview) suffix from related command titles, and simplifying all preconditions/when-clauses to only depend on ChatContextKeys.enabled.

Changes:

  • Removed chat.customizationsMenu.enabled / ChatCustomizationMenuEnabled and updated all gating to rely on ChatContextKeys.enabled.
  • Updated command titles to remove (Preview) for Customizations-related commands.
  • Removed the legacy gear submenu fallback and updated docs to reflect the setting removal.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/constants.ts Removes ChatCustomizationMenuEnabled from ChatConfiguration.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Removes configuration registration for chat.customizationsMenu.enabled.
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts Updates Customizations command titles; simplifies preconditions to ChatContextKeys.enabled.
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts Simplifies when-clauses and removes the legacy gear submenu fallback.
src/vs/workbench/contrib/chat/browser/actions/chatOpenAgentDebugPanelAction.ts Simplifies ViewTitle when-clause and removes unused import.
src/vs/workbench/contrib/chat/browser/tools/toolSetsContribution.ts Simplifies ViewTitle when-clause and removes unused import.
src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts Removes references to the deleted setting from hidden-status logic and config listeners.
src/vs/workbench/browser/parts/titlebar/commandCenterControl.ts Removes the deleted setting from compact-mode logic.
src/vs/sessions/AI_CUSTOMIZATIONS.md Updates documentation to remove references to the deleted setting.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 2

@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering bot commented Apr 7, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/browser/parts/titlebar/commandCenterControl.ts

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Screenshot Changes

Base: c4a91a18 Current: bf14adfe

Changed (3)

editor/inlineCompletions/WordReplacementView/Dark
Before After
before after
editor/suggestWidget/MethodCompletions/Dark
Before After
before after
editor/suggestWidget/MethodCompletions/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the preview gating for the Chat Customizations editor by deleting the chat.customizationsMenu.enabled setting, updating related when-clauses/preconditions, and cleaning up UI labels/documentation to reflect that Customizations is now fully enabled when Chat is enabled.

Changes:

  • Removed chat.customizationsMenu.enabled (ChatCustomizationMenuEnabled) and its configuration registration.
  • Updated command titles to drop “(Preview)” and simplified when-clauses/preconditions to only use ChatContextKeys.enabled.
  • Removed the legacy gear submenu fallback and updated docs accordingly.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/constants.ts Removes the ChatCustomizationMenuEnabled configuration key constant.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Removes configuration schema registration for chat.customizationsMenu.enabled.
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts Updates Customizations command titles and simplifies preconditions.
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts Simplifies when-clauses and removes legacy gear submenu fallback from the Chat view title.
src/vs/workbench/contrib/chat/browser/actions/chatOpenAgentDebugPanelAction.ts Simplifies ViewTitle when-clause and removes unused import.
src/vs/workbench/contrib/chat/browser/tools/toolSetsContribution.ts Simplifies ViewTitle when-clause and removes unused import.
src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts Removes the deleted setting from forced-hidden logic and config change listeners.
src/vs/workbench/browser/parts/titlebar/commandCenterControl.ts Removes the deleted setting from compact-mode forced-hidden logic.
src/vs/sessions/AI_CUSTOMIZATIONS.md Updates documentation to remove references to the deleted setting and preview gating.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 0 new

Remove the "(Preview)" suffix from the Chat Customizations command
titles and remove the `chat.customizationsMenu.enabled` setting that
gated the feature. The customizations editor is now always available
when chat is enabled.

- Remove ChatCustomizationMenuEnabled constant and setting registration
- Simplify when-clauses to only check ChatContextKeys.enabled
- Remove legacy gear submenu fallback for disabled state
- Clean up unused imports across 3 files
- Update AI_CUSTOMIZATIONS.md documentation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshspicer joshspicer force-pushed the copilot/inadequate-mollusk branch from 3c66e28 to 6627a13 Compare April 7, 2026 16:27
@joshspicer joshspicer merged commit 887d6ae into main Apr 7, 2026
37 of 38 checks passed
@joshspicer joshspicer deleted the copilot/inadequate-mollusk branch April 7, 2026 17:56
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants