fix(server): handle quoted ID values in /etc/os-release#308001
Open
tysoncung wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(server): handle quoted ID values in /etc/os-release#308001tysoncung wants to merge 1 commit intomicrosoft:mainfrom
tysoncung wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…2159) - Replace ad-hoc grep/sed parsing with proper source command - Fixes parsing failure on Rocky Linux 8.5 where ID="rocky" - Subshell isolation prevents environment pollution - More robust handling of shell-style variable assignments Closes microsoft#232159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The devcontainer setup script
check-requirements-linux.shfails to parse/etc/os-releaseon Rocky Linux 8.5 because it uses ad-hoc grep/sed parsing that doesn't handle quoted values.On Rocky 8.5, the file contains:
The current regex pattern
ID=([^"]+)fails to match this format, causingOS_IDto be empty and the script to exit with code 1.Solution
Replace the ad-hoc parsing with proper shell variable sourcing:
OS_ID=$(source /etc/os-release && echo $ID)This approach:
/etc/os-releasespec (shell-style variable assignments)Files Changed
resources/server/bin/helpers/check-requirements-linux.shCloses #232159