fix: agents app not closing for update on macOS#308195
Merged
deepak1556 merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit “quit app” API to IHostService and uses it from the Agents (Sessions) update flow to ensure the Agents app fully terminates on macOS (instead of only closing the last window and leaving the process running), preventing post-update blank windows.
Changes:
- Extend
IHostServicewith a newshutdown(): Promise<void>method to represent “quit the entire application”. - Implement
shutdown()for native (Electron) and browser host services, plus update the workbench test host service stub. - Switch the Agents app update action to call
hostService.shutdown()instead ofhostService.close().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/workbenchTestServices.ts | Updates TestHostService to satisfy the new IHostService.shutdown() contract. |
| src/vs/workbench/services/host/electron-browser/nativeHostService.ts | Implements IHostService.shutdown() by delegating to nativeHostService.quit() (full app quit). |
| src/vs/workbench/services/host/browser/host.ts | Adds shutdown() to the IHostService interface with macOS-specific semantics documented. |
| src/vs/workbench/services/host/browser/browserHostService.ts | Implements shutdown() in browser by delegating to existing close() behavior. |
| src/vs/sessions/contrib/accountMenu/browser/account.contribution.ts | Uses hostService.shutdown() in the “Update from VS Code” flow to fully exit the Agents app. |
TylerLeonhardt
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents blank windows of agents app after update via the host app on macOS