actions: add WorkbenchActionBar with telemetry support#308215
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new WorkbenchActionBar wrapper to automatically emit workbenchActionExecuted telemetry for ActionBar-based UI, and adopts it in the inline chat overlay action bar to capture action execution entry points (Fixes #306432).
Changes:
- Added
WorkbenchActionBar(extendsActionBar) that logsworkbenchActionExecutedwhentelemetrySourceis provided. - Updated inline chat overlay widget to instantiate
WorkbenchActionBarand settelemetrySource: 'inlineChatInput.actionBar'.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/actions/browser/actionbar.ts | Introduces WorkbenchActionBar with opt-in workbenchActionExecuted telemetry logging. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts | Switches the inline chat gutter action bar to WorkbenchActionBar and sets a telemetry source. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
sandy081
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
WorkbenchActionBarclass that wrapsActionBarwith automaticworkbenchActionExecutedtelemetry, analogous to howWorkbenchToolBarwrapsToolBar. Adopt it in the inline chat overlay widget.Fixes #306432
Session Context
Key decisions from the development session:
WorkbenchActionBarinsrc/vs/platform/actions/browser/actionbar.tsrather than modifying the baseActionBarclass, following the existing pattern ofWorkbenchToolBar(wrapsToolBar) andWorkbenchButtonBar(wrapsButtonBar).actionbar.tsalongsidetoolbar.tsandbuttonbar.ts, consistent with the existing per-widget file organization.ActionBarusages can adoptWorkbenchActionBarseparately.Changes
src/vs/platform/actions/browser/actionbar.ts:WorkbenchActionBarextendsActionBar, injectsITelemetryService, and subscribes toonDidRunto logworkbenchActionExecutedwhentelemetrySourceis set.src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts: Replacednew ActionBar(...)withinstantiationService.createInstance(WorkbenchActionBar, ...)and addedtelemetrySource: 'inlineChatInput.actionBar'.