Fix crash on null entries in launch.json configurations array#308235
Merged
roblourens merged 3 commits intomicrosoft:mainfrom Apr 14, 2026
Merged
Fix crash on null entries in launch.json configurations array#308235roblourens merged 3 commits intomicrosoft:mainfrom
roblourens merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens debug launch configuration handling to avoid a crash when launch.json contains null (or otherwise invalid) entries in the configurations array, as reported in #307691.
Changes:
- Filter out
null/invalid entries fromlaunch.compoundsandlaunch.configurationsbefore de-duplicating by name. - Add a regression test ensuring
nullentries inconfigurationsare ignored.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts | Filters invalid launch entries before calling distinguishConfigsByName, preventing null.name crashes. |
| src/vs/workbench/contrib/debug/test/browser/debugConfigurationManager.test.ts | Adds coverage for ignoring null entries in launch.configurations. |
roblourens
approved these changes
Apr 14, 2026
Yoyokrazy
approved these changes
Apr 14, 2026
Yoyokrazy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307691 - if that's of any use @hediet
This should parse valid entries in launch.json, but ignore invalid nulls