Skip to content

fix: update copilot job failure condition to include 'succeededWithIssues'#308245

Merged
joaomoreno merged 1 commit intomainfrom
joao/cyan-meadowlark
Apr 7, 2026
Merged

fix: update copilot job failure condition to include 'succeededWithIssues'#308245
joaomoreno merged 1 commit intomainfrom
joao/cyan-meadowlark

Conversation

@joaomoreno
Copy link
Copy Markdown
Member

Co-authored-by: Copilot copilot@github.com

…sues'

Co-authored-by: Copilot <copilot@github.com>
@joaomoreno joaomoreno enabled auto-merge (squash) April 7, 2026 16:15
Copilot AI review requested due to automatic review settings April 7, 2026 16:15
@joaomoreno joaomoreno self-assigned this Apr 7, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/common/downloadCopilotVsix.ts

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Screenshot Changes

Base: 5c2fdfe6 Current: 1af8639b

Changed (1)

editor/inlineCompletionsExtras/JumpToHint/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure Pipelines helper that downloads the Copilot VSIX so it doesn’t treat a Copilot job that completed with warnings (succeededWithIssues) as a failure, aligning with common Azure DevOps result semantics.

Changes:

  • Adjust Copilot job failure detection to consider succeededWithIssues as a non-failure outcome.
Show a summary per file
File Description
build/azure-pipelines/common/downloadCopilotVsix.ts Allows Copilot artifact wait logic to continue when the Copilot job completes as succeededWithIssues rather than aborting early.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@joaomoreno joaomoreno merged commit 5668745 into main Apr 7, 2026
26 of 27 checks passed
@joaomoreno joaomoreno deleted the joao/cyan-meadowlark branch April 7, 2026 16:39
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants