Background - cache folder changes for the various error conditions

[lszomoru]

Migrated from microsoft/vscode-copilot-chat#5029
Original author: @lszomoru

[github-actions]

Screenshot Changes

Base: fc99d59e Current: 8575fc76

Changed (4)

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Light

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Light

Before	After

[Copilot]

Pull request overview

This PR updates the Copilot Chat Sessions workspace-folder change tracking to cache “no changes” results for additional error/edge conditions, reducing repeated work and repeated warnings during a request.

Changes:

• Cache an empty change list when repository properties are missing for a session.
• Cache an empty change list when the git repository (or its changes data) is unavailable.

Show a summary per file

File	Description
extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionWorkspaceFolderServiceImpl.ts	Adds caching for empty workspace changes in more early-return/error paths within getWorkspaceChanges.

Copilot's findings

Comments suppressed due to low confidence (1)

extensions/copilot/src/extension/chatSessions/vscode-node/chatSessionWorkspaceFolderServiceImpl.ts:106

• New behavior caches an empty changes array when no repository (or no repository.changes) is available. Please extend tests to verify subsequent calls hit the cache (e.g., gitService.getRepository is only called once across two getWorkspaceChanges calls for the same session) to ensure this error-path caching keeps working.

			const repository = await this.gitService.getRepository(vscode.Uri.file(repositoryProperties.repositoryPath));
			if (!repository?.changes) {
				this.logService.warn(`[ChatSessionWorkspaceFolderService][getWorkspaceChanges] No repository found for session ${sessionId}`);
				this.workspaceFolderChanges.set(sessionId, []);
				return [];

• Files reviewed: 1/1 changed files
• Comments generated: 2