fix: Add NSLocalNetworkUsageDescription to Info.plist#308457
Merged
deepak1556 merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
macOS shows a "Local Network" privacy prompt when an app opens TCP/UDP connections to devices on the local network over Wi-Fi (per Apple TN3179). Chromium's built-in DNS client (enabled by default on macOS via the kAsyncDns feature flag) sends DNS queries directly over UDP sockets to the system-configured nameservers. On most Wi-Fi networks, the DNS server is in the same-subnet address and triggers the prompt on every launch. Unlike the system resolver path (getaddrinfo → mDNSResponder), the built-in client opens raw UDP sockets from the app process in default (kOff mode) to config.nameservers[] via DnsUDPAttempt::Start() in net/dns/dns_transaction.cc.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing macOS privacy usage string for local network access so that VS Code (and embedded builds) present an appropriate NSLocalNetworkUsageDescription when Chromium’s async DNS triggers the Local Network permission prompt.
Changes:
- Update the main app bundle
Info.plistduring signing to includeNSLocalNetworkUsageDescription. - Apply the same
Info.plistupdate to the embedded app bundle (when present).
Collaborator
Author
lszomoru
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS shows a "Local Network" privacy prompt when an app opens TCP/UDP connections to devices on the local network over Wi-Fi per Apple TN3179.
Chromium's built-in DNS client (enabled by default on macOS via the kAsyncDns feature flag) sends DNS queries directly over UDP sockets to the system-configured nameservers (when DoH is not enabled or in the fallback mode) unlike the system resolver path (getaddrinfo → mDNSResponder). On most Wi-Fi networks, the DNS server is in the same-subnet address and triggers the prompt on every launch.
Before