Fix duplicated Fix entry points on marker hover#308488
Merged
Conversation
When an AI code action is present, skip rendering menu-contributed actions (e.g. inline chat FixDiagnosticsAction) to avoid showing two "Fix" buttons in the hover status bar. Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/52d215c6-9411-43f1-b6b6-15c542e0ed81 Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicated Fix entry points on hover
Fix duplicated Fix entry points on marker hover
Apr 8, 2026
jrieken
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents duplicate “Fix” entry points in the Problems/marker hover status bar by ensuring menu-contributed fix actions only render when no AI quick-fix action is present.
Changes:
- Render menu-contributed marker-hover status bar actions only when an AI code action is not available.
- Preserve existing behavior when there are no quick fixes (menu actions still render) and when the editor is read-only (menu actions still render).
Show a summary per file
| File | Description |
|---|---|
| src/vs/editor/contrib/hover/browser/markerHoverParticipant.ts | Avoids rendering menu-contributed “Fix” actions when an AI quick-fix action is present, preventing duplicated status bar actions. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
ulugbekna
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the AI code action "Fix" (sparkle icon) and the menu-contributed
FixDiagnosticsAction"Fix" (editSparkle icon) render simultaneously in the marker hover status bar, sincerenderMenuActions()is called unconditionally after the AI code action is added.renderMenuActions()into anelsebranch of theaiCodeActioncheck in_renderMarkerStatusbar, so menu-contributed fix actions only render when no AI code action is present