Skip to content

fix remote tests#308562

Merged
joaomoreno merged 1 commit intomainfrom
sandy081/embarrassing-sparrow
Apr 8, 2026
Merged

fix remote tests#308562
joaomoreno merged 1 commit intomainfrom
sandy081/embarrassing-sparrow

Conversation

@sandy081
Copy link
Copy Markdown
Member

@sandy081 sandy081 commented Apr 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2026 17:12
@sandy081 sandy081 self-assigned this Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the native extension management cleanup logic to avoid interfering with extension test runs (notably remote/extension-host test scenarios), by skipping stale auto-update built-in extension removal when extension tests are active.

Changes:

  • Inject IEnvironmentService into ExtensionsScanner to detect extension test runs via extensionTestsLocationURI.
  • Skip removeStaleAutoUpdateBuiltinExtensions() when extensionTestsLocationURI is set.
Show a summary per file
File Description
src/vs/platform/extensionManagement/node/extensionManagementService.ts Avoids cleanup that can disrupt extension test environments by short-circuiting stale auto-update built-in extension removal during tests.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@joaomoreno joaomoreno marked this pull request as ready for review April 8, 2026 17:38
@joaomoreno joaomoreno merged commit fc6d18c into main Apr 8, 2026
40 of 51 checks passed
@joaomoreno joaomoreno deleted the sandy081/embarrassing-sparrow branch April 8, 2026 17:38
@vs-code-engineering vs-code-engineering Bot added this to the 1.116.0 milestone Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants