Skip to content

fix: check message location visibility for failureInVisibleDocument peek #308697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connor4312 merged 1 commit into from
Apr 9, 2026
+7 −0
Merged

fix: check message location visibility for failureInVisibleDocument peek #308697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/vs/workbench/contrib/testing/browser/testingOutputPeek.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,13 @@ export class TestingPeekOpener extends Disposable implements ITestingPeekOpener
if (!Iterable.some(resultItemParents(evt.result, evt.item), i => i.item.uri && editorUris.has(i.item.uri.toString()))) {
return;
}
// Also check that the message location itself is in a visible
// document. The message may point to a different file (e.g. a
// utility) than where the test is defined, and opening a non-
// visible file just to show a peek would be disruptive.
if (!editorUris.has(candidate.location.uri.toString())) {
return;
}
break; //continue
}
case AutoOpenPeekViewWhen.FailureAnywhere:
Expand Down
Loading