Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Xtab response parsing by extracting response-format specific parsing/stream handling out of XtabProvider into a dedicated module, and adds unit tests for the new handlers.
Changes:
- Introduces
responseFormatHandlers.tsto centralize parsing for EditWindowOnly, CodeBlock, EditIntent formats, and UnifiedWithXml. - Updates
xtabProvider.tsto dispatch response parsing via the new handlers and unify fetch-failure handling. - Adds a new Vitest suite covering the new handler behaviors and edge cases.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/xtab/test/node/responseFormatHandlers.spec.ts | Adds targeted unit tests for each response-format handler and UnifiedWithXml sub-modes. |
| extensions/copilot/src/extension/xtab/node/xtabProvider.ts | Replaces inlined parsing logic with handler dispatch and centralizes fetch-failure checks. |
| extensions/copilot/src/extension/xtab/node/responseFormatHandlers.ts | New module implementing response-format parsing and streaming generators for UnifiedWithXml. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
lszomoru
approved these changes
Apr 9, 2026
joshspicer
pushed a commit
that referenced
this pull request
Apr 9, 2026
…of XtabProvider (#308753) * nes: fix: check chatResponseFailure consistently before yielding edits * nes: xtab: cleanup: split response format parsing implementation out of XtabProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.