Add support for parsing bare model names in parseClaudeModelId#308777
Merged
TylerLeonhardt merged 1 commit intomainfrom Apr 9, 2026
Merged
Add support for parsing bare model names in parseClaudeModelId#308777TylerLeonhardt merged 1 commit intomainfrom
TylerLeonhardt merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the Claude model ID parser used by the Copilot Claude chat sessions to also accept “bare” (non-versioned) model names, and updates unit tests to cover the new parsing behavior.
Changes:
- Add a new parsing pattern to accept bare model names (no
claude-prefix/version) intryParseClaudeModelId/parseClaudeModelId. - Introduce
makeBareResultso bare inputs round-trip viatoSdkModelId()/toEndpointModelId()as identity. - Update
claudeModelIdunit tests to validate parsing and formatting of bare names.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/claude/node/claudeModelId.ts | Adds a “bare name” parsing branch and a helper to produce a ParsedClaudeModelId for bare inputs. |
| extensions/copilot/src/extension/chatSessions/claude/node/test/claudeModelId.spec.ts | Adds coverage for bare-name parsing and adjusts “unparseable” cases accordingly. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
extensions/copilot/src/extension/chatSessions/claude/node/claudeModelId.ts
Show resolved
Hide resolved
extensions/copilot/src/extension/chatSessions/claude/node/test/claudeModelId.spec.ts
Show resolved
Hide resolved
lramos15
approved these changes
Apr 9, 2026
joshspicer
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.