Revert "Support timing out hung streams (#308517)"#308779
Merged
Conversation
This reverts commit ba8d730.
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the Copilot networking change that added idle/first-chunk timeouts around SSE streaming reads, restoring the previous “read stream until completion/cancel” behavior to address the reported length-limit/no-output failure.
Changes:
- Removes
withStreamIdleTimeout(and related constants/error) fromfetcherService.ts. - Stops wrapping SSE response bodies with
withStreamIdleTimeoutin the Node streaming processors (OpenAI Responses API, Anthropic Messages API, and SSEProcessor). - Deletes the unit tests that specifically validated the idle-timeout behavior.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/networking/test/node/streamIdleTimeout.spec.ts | Removes tests for the reverted idle-timeout streaming behavior. |
| extensions/copilot/src/platform/networking/node/stream.ts | Restores direct iteration over the SSE body stream (no idle-timeout wrapper). |
| extensions/copilot/src/platform/networking/common/fetcherService.ts | Removes the idle-timeout wrapper implementation and its exported constants/error type. |
| extensions/copilot/src/platform/endpoint/node/responsesApi.ts | Restores direct iteration over the Responses API streaming body. |
| extensions/copilot/src/platform/endpoint/node/messagesApi.ts | Restores direct iteration over the Messages API streaming body. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 0
TylerLeonhardt
approved these changes
Apr 9, 2026
joshspicer
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ba8d730.
Fix #308627