Skip to content

remove duplicate discount text#308821

Merged
eleanorjboyd merged 2 commits intomicrosoft:mainfrom
eleanorjboyd:alright-peafowl
Apr 9, 2026
Merged

remove duplicate discount text#308821
eleanorjboyd merged 2 commits intomicrosoft:mainfrom
eleanorjboyd:alright-peafowl

Conversation

@eleanorjboyd
Copy link
Copy Markdown
Member

Remove duplicate discount info from Auto model tooltip

What was removed

The modelTooltip for AutoChatEndpoint previously included discount information appended to the tooltip text (e.g., "Auto is given a 10% discount."). This has been simplified to always show the base description:

"Auto selects the best model for your request based on capacity and performance."

Why it was removed

The discount value is already shown via the modelDetail variable, which populates two fields on the model:

  • detail — displayed as the description/detail line in the model picker
  • multiplier — displayed as the multiplier badge for Auto models, and also rendered in the model hover content (getModelHoverContent in chatModelsWidget.ts)

The removed tooltip code and the remaining modelDetail code use the same logical checks, just expressed differently:

Condition Removed tooltip code Remaining modelDetail code
No discount (0%) isNoAuthUser || (low === 0 && high === 0) → no discount text high === low && low !== 0 fails → no detail set
Single discount low === high (non-zero) → "{low}% discount" high === low && low !== 0"{low}% discount"
Discount range else"{low}% to {high}% discount" high !== low"{low}% to {high}% discount"

Since the discount info is already visible in the model picker description, showing it again in the tooltip was redundant.

Copilot AI review requested due to automatic review settings April 9, 2026 16:53
@eleanorjboyd eleanorjboyd added the bug Issue identified by VS Code Team member as probable bug label Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes redundant discount messaging from the AutoChatEndpoint tooltip in the Copilot model picker, relying on the existing modelDetail/multiplier UI to communicate discount information.

Changes:

  • Simplified AutoChatEndpoint tooltip text to always show the base “Auto selects…” description.
  • Removed conditional tooltip suffixes that repeated discount details already surfaced elsewhere in the model picker/hover UI.
Show a summary per file
File Description
extensions/copilot/src/extension/conversation/vscode-node/languageModelAccess.ts Removes conditional discount text from the Auto model tooltip, leaving a single base description string.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@eleanorjboyd eleanorjboyd merged commit 6282a77 into microsoft:main Apr 9, 2026
25 of 26 checks passed
@eleanorjboyd eleanorjboyd deleted the alright-peafowl branch April 9, 2026 21:03
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants