Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a UI issue in the chat “thinking” content (fixed-scrolling/collapsed mode) where terminal/tool output can grow without the scroll container updating, causing content to appear cut off.
Changes:
- Add a dedicated
DisposableResizeObserverthat watches child elements (thinking markdown, spinner, and per-item wrappers) for resizes during streaming. - When child resizes occur, refresh cached scroll height and update scroll dimensions so the scrollable area stays accurate.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts | Adds child resize observation in fixed-scrolling mode to keep scroll dimensions in sync as tool/terminal output expands. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
…chatThinkingContentPart.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bryanchen-d
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue where terminals can get cutoff when thinking