handle edge cases while updating built in extensions#308991
Merged
Conversation
alexr00
previously approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds safeguards to prevent unsupported updates/downgrades of built-in (system) extensions during install/update flows, using product quality and built-in extension metadata.
Changes:
- Injects
IProductServiceintoInstallExtensionInProfileTaskto access product quality. - Scans system extensions during installation to detect built-in extensions and block disallowed updates.
- Prevents downgrading below the built-in extension’s version.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/extensionManagement/node/extensionManagementService.ts | Adds product-aware validation that blocks certain built-in extension updates/downgrades. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
…rvice.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chrmarti
previously approved these changes
Apr 10, 2026
deepak1556
previously approved these changes
Apr 10, 2026
joshspicer
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.