Add more correlation ids for external ingest#309051
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates external ingest indexing and deletion flows to propagate a TelemetryCorrelationId through the stack and to emit additional correlation metadata in external ingest telemetry events.
Changes:
- Replace
CallTrackerplumbing withTelemetryCorrelationIdfor external ingest operations (ingest + delete). - Add
workspaceSearchSourceandworkspaceSearchCorrelationIdproperties to external ingest telemetry events for better correlation. - Update unit tests to use
TelemetryCorrelationIdwhen callingExternalIngestIndex.doIngest.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/workspaceChunkSearch/test/node/externalIngest.spec.ts | Switches tests to pass TelemetryCorrelationId into doIngest. |
| extensions/copilot/src/platform/workspaceChunkSearch/node/workspaceChunkSearchService.ts | Uses TelemetryCorrelationId when invoking delete for the external ingest index. |
| extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts | Changes APIs to accept TelemetryCorrelationId and emits additional telemetry correlation properties. |
| extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/codeSearchChunkSearch.ts | Propagates TelemetryCorrelationId into external ingest ingest/delete calls. |
Copilot's findings
Comments suppressed due to low confidence (2)
extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts:384
- The
/* __GDPR__ */metadata block forexternalIngestIndex.updateIndex.errorhas indentation that doesn't match the rest of the block (the newly addedworkspaceSearch*properties are not aligned with the other keys). Please re-indent to match the existing style for GDPR annotations.
"error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth", "comment": "The error message" },
"workspaceSearchSource": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "Caller of the operation" },
"workspaceSearchCorrelationId": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "Correlation id for the operation" },
"durationMs": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true, "comment": "Time taken before failure in milliseconds" }
}
extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts:409
- The
/* __GDPR__ */metadata block forexternalIngestIndex.updateIndex.exceptionhas misaligned indentation for the newly addedworkspaceSearch*properties. Please re-indent these lines to match the surrounding keys for consistency and readability.
"error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth", "comment": "The exception message" },
"workspaceSearchSource": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "Caller of the operation" },
"workspaceSearchCorrelationId": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "Correlation id for the operation" },
"durationMs": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true, "comment": "Time taken before exception in milliseconds" }
}
- Files reviewed: 4/4 changed files
- Comments generated: 1
joshspicer
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.