Skip to content

Add more correlation ids for external ingest#309051

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/convincing-perch
Apr 10, 2026
Merged

Add more correlation ids for external ingest#309051
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/convincing-perch

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Apr 10, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 10, 2026 16:41
@mjbvz mjbvz enabled auto-merge April 10, 2026 16:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates external ingest indexing and deletion flows to propagate a TelemetryCorrelationId through the stack and to emit additional correlation metadata in external ingest telemetry events.

Changes:

  • Replace CallTracker plumbing with TelemetryCorrelationId for external ingest operations (ingest + delete).
  • Add workspaceSearchSource and workspaceSearchCorrelationId properties to external ingest telemetry events for better correlation.
  • Update unit tests to use TelemetryCorrelationId when calling ExternalIngestIndex.doIngest.
Show a summary per file
File Description
extensions/copilot/src/platform/workspaceChunkSearch/test/node/externalIngest.spec.ts Switches tests to pass TelemetryCorrelationId into doIngest.
extensions/copilot/src/platform/workspaceChunkSearch/node/workspaceChunkSearchService.ts Uses TelemetryCorrelationId when invoking delete for the external ingest index.
extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts Changes APIs to accept TelemetryCorrelationId and emits additional telemetry correlation properties.
extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/codeSearchChunkSearch.ts Propagates TelemetryCorrelationId into external ingest ingest/delete calls.

Copilot's findings

Comments suppressed due to low confidence (2)

extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts:384

  • The /* __GDPR__ */ metadata block for externalIngestIndex.updateIndex.error has indentation that doesn't match the rest of the block (the newly added workspaceSearch* properties are not aligned with the other keys). Please re-indent to match the existing style for GDPR annotations.
							"error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth", "comment": "The error message" },
					"workspaceSearchSource": { "classification": "SystemMetaData", "purpose": "FeatureInsight",  "comment": "Caller of the operation" },
					"workspaceSearchCorrelationId": { "classification": "SystemMetaData", "purpose": "FeatureInsight",  "comment": "Correlation id for the operation" },
					"durationMs": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true, "comment": "Time taken before failure in milliseconds" }
					}

extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts:409

  • The /* __GDPR__ */ metadata block for externalIngestIndex.updateIndex.exception has misaligned indentation for the newly added workspaceSearch* properties. Please re-indent these lines to match the surrounding keys for consistency and readability.
						"error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth", "comment": "The exception message" },
					"workspaceSearchSource": { "classification": "SystemMetaData", "purpose": "FeatureInsight",  "comment": "Caller of the operation" },
					"workspaceSearchCorrelationId": { "classification": "SystemMetaData", "purpose": "FeatureInsight",  "comment": "Correlation id for the operation" },
					"durationMs": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true, "comment": "Time taken before exception in milliseconds" }
					}
  • Files reviewed: 4/4 changed files
  • Comments generated: 1

@mjbvz mjbvz merged commit 58064d8 into microsoft:main Apr 10, 2026
29 of 30 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.116.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants