Skip to content

Revert "feat: enable agents app for stable"#309055

Merged
deepak1556 merged 1 commit intomainfrom
robo/revert_agents_in_stable
Apr 10, 2026
Merged

Revert "feat: enable agents app for stable"#309055
deepak1556 merged 1 commit intomainfrom
robo/revert_agents_in_stable

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

This reverts commit b5dd5ac

@deepak1556 deepak1556 added this to the 1.116.0 milestone Apr 10, 2026
@deepak1556 deepak1556 self-assigned this Apr 10, 2026
Copilot AI review requested due to automatic review settings April 10, 2026 17:01
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/code/electron-main/app.ts
  • src/vs/platform/launch/electron-main/launchMainService.ts

@deepak1556 deepak1556 enabled auto-merge (squash) April 10, 2026 17:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previous change that enabled the Agents (embedded) app flow on stable builds by reintroducing quality-based gating in launch/runtime paths and in packaging/build steps.

Changes:

  • Prevent opening the Agents window via --agents on stable (productService.quality !== 'stable').
  • Avoid registering the embedded app with macOS Launch Services on stable.
  • Restrict embedded-app packaging/setup artifacts to insider and exploration qualities.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/vs/platform/launch/electron-main/launchMainService.ts Gates --agents window launch behind non-stable product quality.
src/vs/code/electron-main/app.ts Gates initial Agents window open on --agents and disables embedded-app Launch Services registration on stable.
build/gulpfile.vscode.win32.ts Only includes embedded-app setup definitions for insider/exploration builds.
build/gulpfile.vscode.ts Only packages embedded-app resources and artifacts for insider/exploration builds (and excludes them otherwise).

@deepak1556 deepak1556 merged commit 6f39ac9 into main Apr 10, 2026
30 checks passed
@deepak1556 deepak1556 deleted the robo/revert_agents_in_stable branch April 10, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants