git: clarify that addAICoAuthor only applies to UI commits#309134
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
git: clarify that addAICoAuthor only applies to UI commits#309134yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Update the description for the git.addAICoAuthor setting to explicitly state that it only takes effect for commits made from the Source Control view. Commits made from the command line are not affected because the extension does not install a prepare-commit-msg hook. Fixes microsoft#297415
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
git.addAICoAuthorsetting only takes effect for commits made from the VS Code Source Control view; commits made from the command line are not affected because the extension does not install aprepare-commit-msghook. The current setting description does not mention this, which can mislead users into expecting CLI commits to gain aCo-authored-bytrailer too.This PR updates the setting description to make the scope explicit.
Fixes #297415
Test plan
git.addAICoAuthordescription in Settings UI shows the new wording explaining it only applies to commits made from the Source Control viewextensions/git/package.nls.json