Skip to content

Fix crash from nulled _session in ChatModel.dispose() #309570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roblourens merged 3 commits into from
Apr 13, 2026
Merged

Fix crash from nulled _session in ChatModel.dispose() #309570

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d7e761
Fix crash from nulled _session in ChatModel.dispose()
roblourens Apr 13, 2026
63f6cca
Keep safe GC cleanup, only remove _session null-out
roblourens Apr 13, 2026
52cf902
Merge branch 'main' into roblou/fix-session-null-crash
roblourens Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/vs/workbench/contrib/chat/common/model/chatModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2819,12 +2819,7 @@ export class ChatModel extends Disposable implements IChatModel {
}

override dispose() {
this._requests.forEach(r => {
r.response?.dispose();
// Break back-reference from request to this model
// eslint-disable-next-line local/code-no-any-casts, @typescript-eslint/no-explicit-any
(r as any)._session = undefined;
});
this._requests.forEach(r => r.response?.dispose());
this._onDidDispose.fire();

super.dispose();
Comment thread
roblourens marked this conversation as resolved.
Expand Down
Loading