Skip to content

Remove page.route handler that breaks loading complex pages#309640

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/int-browser-fix
Apr 13, 2026
Merged

Remove page.route handler that breaks loading complex pages#309640
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/int-browser-fix

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

Fixes integrated browser not working (regression from network filter changes).

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 13, 2026 21:54
@dmitrivMS dmitrivMS added browser-integration Web browsing features integrated into VS Code (e.g. integrated browser) release-cherry-pick Automated cherry-pick between release and main branches labels Apr 13, 2026
@dmitrivMS dmitrivMS self-assigned this Apr 13, 2026
@dmitrivMS dmitrivMS requested a review from kycutler April 13, 2026 21:54
@dmitrivMS dmitrivMS enabled auto-merge April 13, 2026 21:54
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@jruales

Matched files:

  • src/vs/platform/browserView/node/playwrightTab.ts

@dmitrivMS dmitrivMS added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Apr 13, 2026
@dmitrivMS dmitrivMS removed the release-cherry-pick Automated cherry-pick between release and main branches label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 8eb2168b Current: dfeb9c88

Changed (1)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

@vs-code-engineering
Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.116 when merged.

@dmitrivMS dmitrivMS disabled auto-merge April 13, 2026 22:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a regression where the integrated browser fails to load complex/dynamic pages by removing a Playwright page.route('**/*', …) request interception handler that was introduced for agent network policy filtering.

Changes:

  • Removed the Playwright page-level network request routing/interception block in the integrated browser tab wrapper.
Show a summary per file
File Description
src/vs/platform/browserView/node/playwrightTab.ts Removes global Playwright request interception that was breaking complex page loads in the integrated browser.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/vs/platform/browserView/node/playwrightTab.ts
@dmitrivMS dmitrivMS merged commit da349c6 into main Apr 13, 2026
30 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/int-browser-fix branch April 13, 2026 22:34
@dmitrivMS dmitrivMS added this to the 1.116.0 milestone Apr 13, 2026
@vs-code-engineering vs-code-engineering bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser-integration Web browsing features integrated into VS Code (e.g. integrated browser) release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants