Improve terminal unsandbox retry confirmation

[dileepyavan]

Summary

Fixes #308506

This improves the automatic unsandbox retry confirmation shown after a sandboxed terminal command fails due to sandbox restrictions.

Changes:

• Removes the markdown link from the retry confirmation title so it reads plainly, for example:
  • Run \bash` command outside the sandbox?`
  • Run \bash` command outside the sandbox to access `example.com`?`
• Keeps the existing sandbox documentation link behavior for the normal/pre-run unsandbox confirmation UI; this change only affects the retry confirmation UI.
• Separates the retry-confirmation decision from sandbox analyzer force-approval:
  • sandbox force-approval can still suppress the initial sandboxed command confirmation
  • commands that would otherwise require confirmation still require confirmation before automatic unsandbox retry

Testing

• npm run transpile-client
• ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts

Result:

• 157 passing
• 105 pending

Note: the focused test command was run unsandboxed because sandboxed execution repeatedly failed during Electron bootstrap while resolving/downloading from github.com, before tests executed.

[github-actions]

Screenshot Changes

Base: 9374b64c Current: 9e0771e7

Changed (17)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light

Before	After

agentSessionsViewer/CompletedRead/Dark

Before	After

agentSessionsViewer/CompletedRead/Light

Before	After

agentSessionsViewer/FailedWithoutDuration/Dark

Before	After

agentSessionsViewer/FailedWithoutDuration/Light

Before	After

agentSessionsViewer/WithFileChangesList/Dark

Before	After

agentSessionsViewer/WithFileChangesList/Light

Before	After

agentSessionsViewer/WithBadge/Dark

Before	After

agentSessionsViewer/WithBadge/Light

Before	After

agentSessionsViewer/WithMarkdownBadge/Dark

Before	After

agentSessionsViewer/WithMarkdownBadge/Light

Before	After

agentSessionsViewer/WithBadgeAndDiff/Dark

Before	After

agentSessionsViewer/WithBadgeAndDiff/Light

Before	After

agentSessionsViewer/BackgroundProvider/Dark

Before	After

agentSessionsViewer/BackgroundProvider/Light

Before	After

agentSessionsViewer/ClaudeProvider/Dark

Before	After

agentSessionsViewer/ClaudeProvider/Light

Before	After

[Copilot]

Pull request overview

Improves the UX and logic around the “automatic unsandbox retry” confirmation shown after a sandboxed terminal command fails due to sandbox restrictions, keeping the pre-run unsandbox confirmation behavior unchanged.

Changes:

• Removes the sandbox documentation markdown link from the retry confirmation title by introducing a dedicated title builder.
• Separates “force auto-approval” from the retry-confirmation decision so forced approvals can still suppress the initial confirmation but not suppress the retry elicitation.
• Adds tests covering the new retry title text and the force-approval vs retry-confirmation behavior.

Show a summary per file

File	Description
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts	Refactors auto-approval logic to preserve retry confirmations and adds a helper to generate a plain retry title (no doc link).
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts	Adds unit tests validating the retry title text and ensuring forced auto-approval still requires retry elicitation when appropriate.

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 1